chore: revised Slack notification workflow - #78
Open
burigolucas wants to merge 1 commit into
Open
Conversation
- fixed slack notification formatting - added continue on error when slack notification fails
burigolucas
changed the title
tech2734
approved these changes
Sep 1, 2026
tech2734
left a comment
tech2734
left a comment
There was a problem hiding this comment.
LGTM. The $'...' quoting fix for newlines is correct, and the continue-on-error with actionable warning output is a clean approach — keeps Slack failures from masquerading as code quality issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following two fixes are implemented:
Description
Type of Change
Pull Request Title