fix(v2): standardise managed-by label across roles - #82
Open
tech2734 wants to merge 7 commits into
Open
Conversation
Replace hardcoded app.kubernetes.io/managed-by values with a configurable role variable defaulting to ansible-migration-factory. - mtv_provider: add mtv_provider_managed_by_label variable, use it in provider.yml.j2 and provider_secret.yml.j2 templates - utility_openshift_target_credential: change default from "ansible" to "ansible-migration-factory" for consistency Co-authored-by: Cursor <cursoragent@cursor.com>
tech2734
added a commit
to tech2734/openshift_virtualization_migration
that referenced
this pull request
Sep 1, 2026
Replace hardcoded app.kubernetes.io/managed-by value with mtv_maps_managed_by_label variable, consistent with the approach in mtv_provider (PR redhat-cop#82). Co-authored-by: Cursor <cursoragent@cursor.com>
Update docsible-generated README to reflect the managed-by label default change from "ansible" to "ansible-migration-factory". Co-authored-by: Cursor <cursoragent@cursor.com>
Add title, required, and description comment blocks above each variable in defaults/main.yml for both roles. Regenerate READMEs via docsible. Add .docsible to .gitignore. All roles now have standardised docsible headings: - aap_seed (41 variables) - mtv_provider (14 variables) - mtv_query_inventory (already done) - utility_aap_deploy (already done) - utility_openshift_target_credential (already done) Co-authored-by: Cursor <cursoragent@cursor.com>
Re-run update-documentation.sh to regenerate READMEs with the same custom template used by CI, fixing pre-commit check failures caused by docsible version/template mismatch. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
READMEs generated by docsible start with H2 (## role_name) which violates MD041 (first-line-heading). Add a STATIC CONTENT block with an H1 header to aap_seed, mtv_provider, and utility_openshift_target_credential, matching the pattern used by mtv_query_inventory. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
@tech2734 a few concurrent enhancements have been integrated. Would you be able to resolve the merge conflicts and we can look at getting this feature integrated? |
Resolve conflicts in aap_seed/defaults/main.yml by merging upstream's new EE variables (PR redhat-cop#76) with our docsible headings. Accept upstream's CHANGELOG.rst and aap_seed README, then regenerate README via docsible to reflect the merged defaults. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
should be good now |
tech2734
added a commit
to tech2734/openshift_virtualization_migration
that referenced
this pull request
Sep 2, 2026
Replace hardcoded app.kubernetes.io/managed-by value with mtv_maps_managed_by_label variable, consistent with the approach in mtv_provider (PR redhat-cop#82). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.kubernetes.io/managed-byvalues with configurable role variables defaulting toansible-migration-factoryutility_openshift_target_credentialdefault from"ansible"to"ansible-migration-factory"for consistency across all roles# title:/# required:/# description:headings toaap_seedandmtv_providerdefaults, completing standardisation across all v2 rolesaap_seed,mtv_provider, andutility_openshift_target_credential.docsibleto.gitignoreManaged-by label changes
mtv_providermtv_provider_managed_by_labelvariable; templates now reference it instead of hardcodingutility_openshift_target_credentialutility_openshift_target_credential_managed_by_labelfrom"ansible"to"ansible-migration-factory"Docsible heading standardisation
All v2 roles now have docsible headings on every variable in
defaults/main.yml:aap_seedmtv_providermtv_query_inventoryutility_aap_deployutility_openshift_target_credentialNote
The
mtv_mapsrole (PR #80) also hardcodes the managed-by value and will need the same treatment once merged. Themtv_plansrole (PR #81) is missing the label entirely.Test plan
mtv_providertemplates render with the correct labelutility_openshift_target_credentialresources get the updated label