Skip to content

feat: support custom annotations in principal's service - #1299

Draft
jparsai wants to merge 2 commits into
redhat-developer:masterfrom
jparsai:metalib-v1
Draft

jparsai wants to merge 2 commits into
redhat-developer:masterfrom
jparsai:metalib-v1

Conversation

@jparsai

@jparsai jparsai commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Assisted by: Cursor

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Assisted by: Cursor

Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jparsai

jparsai commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator Author

/test all

Assisted by: Cursor

Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jparsai

jparsai commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator Author

/test all

@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown

@jparsai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-sequential 484760b link false /test v4.14-kuttl-sequential
ci/prow/v4.14-kuttl-parallel 484760b link false /test v4.14-kuttl-parallel
ci/prow/v4.19-kuttl-parallel 484760b link true /test v4.19-kuttl-parallel
ci/prow/v4.19-kuttl-sequential 484760b link true /test v4.19-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant