Skip to content

fix(promoter): mount writable temporary storage for the controller #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsell-rh wants to merge 3 commits into
base: master
Choose a base branch
from
+26 −0
Open

fix(promoter): mount writable temporary storage for the controller #1302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6e856f
fix(promoter): mount writable temporary storage for the controller
jsell-rh Sep 17, 2026
f753476
refactor(promoter): address temporary storage review comments
jsell-rh Sep 17, 2026
65fbf2f
test(promoter): keep the existing deployment test structure
jsell-rh Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions argocd-operator/controllers/gitopspromoter/deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ func createControllerConfig() deploymentConfig {
securityContext: buildControllerSecurityContext(),
livenessProbe: buildControllerLivenessProbe(),
readinessProbe: buildControllerReadinessProbe(),
volumes: buildControllerVolumes(),
volumeMounts: buildControllerVolumeMounts(),
}
}

Expand Down Expand Up @@ -445,6 +447,28 @@ func buildAPIServerArgs() []string {
}
}

// buildControllerVolumes provides writable storage for Git clones and temporary index files.
func buildControllerVolumes() []corev1.Volume {
return []corev1.Volume{
{
Name: "tmp",
VolumeSource: corev1.VolumeSource{
EmptyDir: &corev1.EmptyDirVolumeSource{},
},
},
}
}

// buildControllerVolumeMounts mounts the controller's writable temporary storage.
func buildControllerVolumeMounts() []corev1.VolumeMount {
return []corev1.VolumeMount{
{
Name: "tmp",
MountPath: "/tmp",
},
}
}

// buildAPIServerVolumes builds the Volumes for the API Server
func buildAPIServerVolumes(cr *argoproj.ArgoCD) []corev1.Volume {
return []corev1.Volume{
Expand Down
2 changes: 2 additions & 0 deletions argocd-operator/controllers/gitopspromoter/deployment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,8 @@ func TestReconcilePromoterControllerDeployment_PromoterEnabled(t *testing.T) {
assert.Equal(t, cfg.securityContext, retrievedDeployment.Spec.Template.Spec.Containers[0].SecurityContext)
assert.Equal(t, cfg.livenessProbe, retrievedDeployment.Spec.Template.Spec.Containers[0].LivenessProbe)
assert.Equal(t, cfg.readinessProbe, retrievedDeployment.Spec.Template.Spec.Containers[0].ReadinessProbe)
assert.Equal(t, cfg.volumeMounts, retrievedDeployment.Spec.Template.Spec.Containers[0].VolumeMounts)
assert.Equal(t, cfg.volumes, retrievedDeployment.Spec.Template.Spec.Volumes)
}

func TestReconcilePromoterAPIServerDeployment_PromoterDisabled(t *testing.T) {
Expand Down