Skip to content

port lazy_loader perf and native PEP810 + add python3.15 support - #6930

Open
benedikt-bartscher wants to merge 18 commits into
reflex-dev:mainfrom
benedikt-bartscher:use-lazy-loader-branch
Open

port lazy_loader perf and native PEP810 + add python3.15 support#6930
benedikt-bartscher wants to merge 18 commits into
reflex-dev:mainfrom
benedikt-bartscher:use-lazy-loader-branch

Conversation

@benedikt-bartscher

@benedikt-bartscher benedikt-bartscher commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

@codspeed-hq

codspeed-hq Bot commented Aug 22, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 4.67%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 5 improved benchmarks
✅ 35 untouched benchmarks
⏩ 8 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
test_evaluate_page[_complicated_page] 62.6 ms 59.3 ms +5.61%
test_evaluate_page_with_hooks[_complicated_page] 63.1 ms 59.8 ms +5.6%
test_evaluate_page[_stateful_page] 10.5 ms 10 ms +4.64%
test_evaluate_page_with_hooks[_stateful_page] 11 ms 10.6 ms +4.31%
test_console_log 812.7 µs 787.6 µs +3.19%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing benedikt-bartscher:use-lazy-loader-branch (729ccc4) with main (9165dc6)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@greptile-apps

greptile-apps Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because no blocking failure remains in the eligible follow-up review scope.

Summary

  • Caches resolved lazy attributes to avoid repeated __getattr__ lookups.
  • Adds Python 3.15 compatibility handling for dataclass and TypedDict internals.
  • Extends CI matrices and adjusts dependency markers for Python 3.15.

Reviews (17) · Last reviewed commit: "Merge branch 'main' into use-lazy-loader..."

@benedikt-bartscher benedikt-bartscher changed the title port lazy_loader performance improvements and native PEP810 port lazy_loader perf and native PEP810 + add python3.15 support Aug 22, 2026
@benedikt-bartscher
benedikt-bartscher marked this pull request as ready for review August 22, 2026 14:40
@benedikt-bartscher
benedikt-bartscher requested a review from a team as a code owner August 22, 2026 14:40

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 17 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .github/workflows/unit_tests.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant