Conversation
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| --primary-5: var(--c-slate-5); | ||
| --primary-6: var(--c-slate-6); | ||
| /* Internal inputs retain their flush focus treatment, using neutral ink. */ | ||
| --primary-a6: var(--secondary-a6); |
There was a problem hiding this comment.
The editorial theme changes the solid --primary-* colors to neutral slate, but only changes --primary-a6 in the alpha scale. Existing components still use the other violet alpha colors—for example, docs page actions combine neutral --primary-7 with violet --primary-a8 and use violet --primary-a3 and --primary-a4 backgrounds in dark mode. This leaves mismatched violet tints in the new neutral theme; please map the full primary alpha scale to matching neutral values.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Merging this PR will not alter performance
Comparing 
Footnotes
|
| rx.text( | ||
| "pip install " + category["package_name"], | ||
| as_="p", | ||
| class_name="font-small truncate flex-1 min-w-0", | ||
| class_name="font-mono text-xs truncate flex-1 min-w-0", | ||
| ), |
There was a problem hiding this comment.
The new install-command control renders its label with rx.text. The docs-app directive requires UI elements to use rx.el.* with Tailwind instead of legacy primitives such as rx.text, so this repository requirement must be satisfied before merging.
| rx.text( | |
| "pip install " + category["package_name"], | |
| as_="p", | |
| class_name="font-small truncate flex-1 min-w-0", | |
| class_name="font-mono text-xs truncate flex-1 min-w-0", | |
| ), | |
| rx.el.p( | |
| "pip install " + category["package_name"], | |
| class_name="font-mono text-xs truncate flex-1 min-w-0", | |
| ), |
Context Used: docs/app/CLAUDE.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| rx.link( | ||
| rx.cond( | ||
| active, | ||
| rx.el.div( | ||
| class_name="absolute left-0 top-1/2 -translate-y-1/2 w-full h-8 rounded-lg bg-secondary-3 z-[-1]", | ||
| ), | ||
| rx.fragment(), | ||
| ), | ||
| rx.flex( | ||
| rx.cond( | ||
| active, | ||
| rx.el.div( | ||
| class_name="pointer-events-none absolute -bottom-1 -top-1 left-0 w-px bg-primary-10", | ||
| ), | ||
| rx.fragment(), | ||
| ), | ||
| rx.text( | ||
| title, | ||
| class_name=rx.cond( | ||
| active, | ||
| "m-0 pl-4 text-sm font-[525] text-primary-10 transition-color", | ||
| "m-0 w-full text-sm font-[525] text-secondary-11 transition-color hover:text-secondary-12", | ||
| ), | ||
| ), | ||
| class_name=rx.cond( | ||
| active, | ||
| f"relative {guide_margin_class} flex h-8 max-w-[14rem] items-center", | ||
| "relative flex h-8 items-center pl-4", | ||
| class_name="m-0 w-full text-sm", | ||
| ), | ||
| class_name="relative flex items-center px-3", | ||
| ), | ||
| href=href, | ||
| underline="none", | ||
| class_name=rx.cond( | ||
| active, | ||
| "relative block w-full", | ||
| f"block w-full {guide_margin_class}", | ||
| ), | ||
| aria_current=rx.cond(active, "page", "false"), | ||
| class_name=f"docs-sidebar-leaf relative block {guide_margin_class}", |
There was a problem hiding this comment.
The shared sidebar leaf now exposes its active state only through aria-current and classes whose visible active, hover, and focus treatments are defined in the opt-in editorial stylesheet. Consumers using the default non-editorial SharedSiteStylesPlugin therefore lose the visible current-page indicator and keyboard-focus treatment. Keep baseline state styling in the shared component or provide equivalent styling through the default theme.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 participant
Bring the documentation into the editorial design introduced in marketing PR #102, with consistent typography, neutral light/dark colors, restrained borders, and shared navigation and footer styling.
Changes
/docs/.high_contrastfrom the introduction counter and correct invalid nesting in integration cards and the low-level form example.The shared package exposes the visual system through
SharedSiteStylesPlugin(editorial=True). Existing consumers can retain the default theme.Validation
pre-commit run --all-filesandgit diff --checkpass.The custom-component gallery's external data endpoint is not configured in the local preview, so populated gallery results were not visually verified. No external forms were submitted.
Type of change
Package news fragments are included.