Skip to content

fix: explain uninitialized pass credential store - #3166

Open
bghira wants to merge 1 commit into
replicate:mainfrom
bghira:issue-842-pass-not-initialized
Open

bghira wants to merge 1 commit into
replicate:mainfrom
bghira:issue-842-pass-not-initialized

Conversation

@bghira

@bghira bghira commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Closes #842

Summary

  • capture stderr from Docker credential helpers when storing login credentials
  • recognize the pass not initialized failure and explain how to create a GPG key and initialize pass
  • preserve other credential-helper stderr in the returned error
  • add a regression test using a fake credential helper

Validation

  • go test ./pkg/...
  • go vet ./pkg/docker
  • go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.10.1 run ./pkg/docker/...
  • git diff --check

@bghira
bghira requested a review from a team as a code owner August 31, 2026 15:43

@anish-sahoo anish-sahoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ci breaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cog login fails silently if pass is uninitialized

2 participants