fix(contacts): properties response shape - #254
Open
gabrielmfern wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gabrielmfern
marked this pull request as ready for review
August 14, 2026 18:40
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Corrects the Contact.properties typing to match the actual API response (value+type objects), updates the example and test to the real shape, and removes the field from list fixtures since only the retrieve endpoint returns it. A bounded, test-pinned bug fix with no request or operational changes.
Re-trigger cubic
Approval not submitted
This repository is configured to approve as @klotty, but that approval identity is unavailable.
Reconnect or verify the approval identity in repository settings.
cubic left this as a normal review comment instead of falling back to a Cubic App approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /contacts/:idreturnspropertieswhere each entry is a{value, type}object, not a flat key→string map — the previousDict[str, Any]typing didn't express that. Adds aContactPropertyValueTypedDict (value: string, number, or boolean;type), updates the get-contact test and example to the real shape, and removespropertiesfrom the list-response fixtures since only the retrieve endpoint returns it. Create/update request params stay flat maps.Matches resend-node's
get-contact.interface.tsand resend-rust'sContactPropertyResponse.docs: https://resend.com/docs/api-reference/contacts/get-contact
🤖 Generated with Claude Code
Summary by cubic
Corrects the
propertiesresponse shape forGET /contacts/:idto map each property name to an object withvalueandtypeinstead of a flat string map, aligning with the API and preventing misuse. Matchesresend-nodeandresend-rust.ContactPropertyValue(value: string/number/boolean;type: "string" | "number" | "boolean") and updatesContact.propertiestoDict[str, ContactPropertyValue].name -> value (type)and adjusts tests; removespropertiesfrom list-response fixtures since only the retrieve endpoint returns it.Migration
contact["properties"][name]["value"]and, if needed,["type"].Dict[str, ContactPropertyValue]forproperties.Written for commit 2857bdf. Summary will update on new commits.