Skip to content

Fix REGISTER's Via header ignoring the target's actual transport #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
youngnsx wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix REGISTER's Via header ignoring the target's actual transport #141

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4013cd9
Fix REGISTER's Via header ignoring the target's actual transport
youngnsx Sep 5, 2026
053a111
fix: reuse effective REGISTER connection for Via and sending
yeoleobun Sep 14, 2026
7c3643c
test: remove added registration regression tests
yeoleobun Sep 14, 2026
487b5c5
revert: remove follow-up changes to REGISTER Via fix
yeoleobun Sep 14, 2026
cd7771b
style: format REGISTER Via transport fix
yeoleobun Sep 14, 2026
aee20b0
Merge branch 'main' into fix/register-via-transport
yeoleobun Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/dialog/registration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,10 +396,15 @@ impl Registration {
// this is safe to do unconditionally rather than only for TCP/TLS.
let via = match SipAddr::try_from(&server) {
Ok(target_addr) => {
match self.endpoint.transport_layer.lookup(&target_addr, None).await {
Ok((connection, _resolved)) => {
self.endpoint.get_via(Some(connection.get_addr().clone()), None)?
}
match self
.endpoint
.transport_layer
.lookup(&target_addr, None)
.await
{
Ok((connection, _resolved)) => self
.endpoint
.get_via(Some(connection.get_addr().clone()), None)?,
Err(_) => self.endpoint.get_via(None, None)?,
}
}
Expand Down
Loading