fix(vulkan): return nullptr on initialization failure instead of calling abort - #118
Closed
charliesbot wants to merge 1 commit into
Closed
fix(vulkan): return nullptr on initialization failure instead of calling abort#118charliesbot wants to merge 1 commit into
charliesbot wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the PR Charlie. We took inspiration from this to strengthen the Vulkan initialization story. That has now been merged in this commit. Vulkan initialization has many more pathways which fail gracefully than before. Closing this issue as I believe the intent has been addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Vulkan initialization or GPU object creation fails (such as on Android devices missing required Vulkan 1.1 features or hardware support), VK_CHECK previously called abort(), causing process death (SIGABRT). This prevented higher level callers, such as the Android Kotlin CommandQueue runCatching block, from catching the initialization failure and gracefully falling back to OpenGL ES.
This change updates vk_check in vkutil.hpp to return false on error instead of calling abort(), and adds a check in RenderContextVulkanImpl::MakeContext() to return nullptr if GPU object creation fails.
Corresponding unit tests have been added to pls_render_context_test.cpp to verify vk_check error handling and context initialization failure fallback.