test(execution): cover context top-level await - #1956
Merged
NathanFlurry merged 1 commit intoSep 17, 2026
Merged
NathanFlurry merged 1 commit into
NathanFlurry merged 1 commit into
Conversation
Member
Author
|
Stack for rivet-dev/agentos
Get stack: change zznlqovp |
This was referenced Sep 2, 2026
NathanFlurry
force-pushed
the
stack/docs-execution-define-context-module-semantics-soypllku
branch
from
September 17, 2026 02:16
9807101 to
ae61189
Compare
Base automatically changed from
stack/docs-execution-define-context-module-semantics-soypllku
to
main
September 17, 2026 02:43
Add a wire-level native-sidecar test that an inline format=Module JavaScript source using top-level await in a named context settles and exits Succeeded/0. Ports #1956 onto main; depends on the inline module format fix from #1949 and fails without it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
NathanFlurry
force-pushed
the
stack/test-execution-cover-context-top-level-await-zznlqovp
branch
from
September 17, 2026 02:55
f8a089c to
8d731b2
Compare
![the-company-company[bot]](https://avatars.githubusercontent.com/in/3874572?s=60&v=4){kind=small}
| wire::RequestPayload::JavaScriptExecutionRequest(wire::JavaScriptExecutionRequest { | ||
| process: context_process_options("module-context"), | ||
| source: String::from( | ||
| "const value = await Promise.resolve(42);\n\ |
There was a problem hiding this comment.
🟠 Medium · The test never exercises pending top-level await
Promise.resolve(42) settles during the unconditional microtask checkpoint in execute_module, before the runtime checks the module-evaluation promise. Consequently this case never enters set_pending_module_evaluation or the session event-loop wait path, so an implementation that stops waiting for genuinely asynchronous top-level await would still pass. Use a promise that remains pending past the first checkpoint (for example a timer- or bridge-driven promise) and assert an effect produced after that await.
NathanFlurry
deleted the
stack/test-execution-cover-context-top-level-await-zznlqovp
branch
September 17, 2026 03:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.