fix(native-sidecar): Clone cancel descriptor under single VmState borrow - #1993
Open
mittal-parth wants to merge 1 commit into
Open
mittal-parth wants to merge 1 commit into
mittal-parth wants to merge 1 commit into
Conversation
CancelExecution set deadline_task via get_mut, then called get() to clone the descriptor while that RefMut was still live, which panicked with "RefCell already mutably borrowed". This change clones the descriptor from the same get_mut, fixing the panic on abort / cancel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CancelExecutionsetdeadline_taskviaget_mut, then calledget()to clone the descriptor while thatRefMutwas still live.get_mut, fixing the panic on abort / cancel.Tests
All tests under
crates/native-sidecar/tests/language_execution.rsnow passRef
Closes #1988