Preserve subscription serializer round trips - #5723
Open
ydah wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on #5722 with two additional cases where
GraphQL::Subscriptions::Serialize.dumpand.loaddon't round-trip their input.First, arrays are treated as GlobalID arrays based only on their first element:
The loader attempts to read
__gid__from every remaining element. Other mixed values may produce nil IDs and causeGlobalID::Locator.locate_manyto return incorrect results or fail.Second, Symbol and String keys with the same name are collapsed when keys are converted to strings:
This PR only uses the batched
GlobalID::Locator.locate_manypath when every array element is a GlobalID wrapper. Mixed arrays use the existing recursive loading path, while homogeneous GlobalID arrays retain batched lookup.For Hash key collisions, Symbol-keyed values are stored separately in the existing
__sym_keys__metadata. Hashes without collisions retain their existing serialized format.