Avoid repeated fragment complexity analysis - #5724
Open
ydah wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve query complexity analysis for recursively reused fragments.
QueryComplexitycurrently visits each fragment spread as an independent expanded tree. A fragment graph such as:revisits the same nested selections for every path, causing analysis time to grow exponentially with the fragment level.
This PR calculates concrete object selections as a DAG and memoizes shared fragment complexity. Built-in
QueryComplexityandMaxQueryComplexityanalyzers use the precomputed result, while abstract selections and custom analyzer subclasses retain the existing visitor path.Multiplex analyzers decide visitation per query, preventing an unsupported query in the same multiplex from causing already-precomputed queries to be expanded again.
Benchmark
Measured on Ruby 4.0.0 using binary fragment expansion. The previous implementation was measured through an analyzer subclass that retains the original visitor path.
The level-20 query now completes complexity analysis instead of reaching the validation timeout.