Fix for transpile issue with typecast statement with intersection and inline interface - #1652
Merged
Merged
Conversation
markwpearce
changed the title
`TypeExpression.getName()` only handled dotted-get chains, returning `undefined` for unions/intersections, inline interfaces, typed arrays, typed function types, and groupings. `TypecastStatement.transpile()` put that `undefined` straight into its TranspileResult, crashing source-map. Adds `util.getTypeExpressionName()`, which reconstructs the written name for those shapes, and uses it as the fallback in `getName()`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This test builds 100 components and validates the whole program twice, which runs ~300ms locally but blew past the default 2s mocha timeout on a loaded macOS CI runner. Bumped just this test to 30s rather than raising the global timeout, which would mask real hangs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
TwitchBronBron
marked this pull request as ready for review
September 2, 2026 13:56
TwitchBronBron
approved these changes
Sep 2, 2026
TwitchBronBron
left a comment
TwitchBronBron
left a comment
Member
There was a problem hiding this comment.
I think I got it fixed. We'll ship this, and feel free to open a new PR with any further issues you might encounter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for: #1651