[ntuple] add support for automatic schema evolution of SoA fields - #23064
Open
jblomer wants to merge 5 commits into
Open
[ntuple] add support for automatic schema evolution of SoA fields#23064jblomer wants to merge 5 commits into
jblomer wants to merge 5 commits into
Conversation
pcanal
reviewed
Aug 11, 2026
Comment on lines
+987
to
+992
| // Other artificial fields simply don't read at all. This does not work here because then | ||
| // the vector elements of trivial types would be left uninitialized (complex types explicitly call | ||
| // the constructor on vector resize). Thus we explicitly default-initialize trivial types. | ||
| // Note that this causes a subtle difference in behavior: if the added member is default-initialized to | ||
| // a non-zero value, this will be forgotten in the SoA layout. | ||
| if (memberField->GetTraits() & kTraitTriviallyConstructible) { |
Member
There was a problem hiding this comment.
Does this need to be part of some user level documentation?
pcanal
reviewed
Aug 11, 2026
| int fInt1; | ||
| int fInt2; | ||
| int fInt3; | ||
| ClassDefNV(RemovedMemberRecord, 2) |
Member
There was a problem hiding this comment.
Maybe
Suggested change
| ClassDefNV(RemovedMemberRecord, 2) | |
| ClassDefInlineNV(RemovedMemberRecord, 2) |
Test Results 23 files 23 suites 5d 1h 54m 4s ⏱️ For more details on these failures, see this check. Results for commit 6e665d8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #19230