[RF][RS] Add SetSigned() option to the AsymptoticCalculator - #23105
Merged
guitargeek merged 1 commit intoAug 21, 2026
Conversation
guitargeek
force-pushed
the
asymptotic-calculator-signed
branch
from
August 19, 2026 10:39
df080ea to
847b9d6
Compare
guitargeek
changed the title
Support the signed (uncapped) profile likelihood test statistic in the AsymptoticCalculator, like the ProfileLikelihoodTestStat already does with its SetSigned() option. When enabled and the best fit value of the POI is beyond the tested value, the sign of sqrt(qmu) is flipped instead of setting qmu to zero. The Gaussian asymptotic formulae remain valid in that case, so the p-values continue above 0.5 instead of saturating there. The qtilde corrections are skipped when the sign was flipped, because they apply when the best fit value is at the POI boundary, which is on the other side of the tested value. The option has no effect for the two-sided test statistics, whose asymptotic p-value formulae are symmetric in the sign. Closes [ROOT-8257](https://its.cern.ch/jira/browse/ROOT-8257). 🤖 Done with the help of AI
guitargeek
force-pushed
the
asymptotic-calculator-signed
branch
from
August 19, 2026 10:40
847b9d6 to
72d935c
Compare
Test Results 23 files 23 suites 3d 17h 10m 0s ⏱️ For more details on these failures, see this check. Results for commit 72d935c. |
dpiparo
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support the signed (uncapped) profile likelihood test statistic in the AsymptoticCalculator, like the ProfileLikelihoodTestStat already does with its SetSigned() option.
When enabled and the best fit value of the POI is beyond the tested value, the sign of sqrt(qmu) is flipped instead of setting qmu to zero. The Gaussian asymptotic formulae remain valid in that case, so the p-values continue above 0.5 instead of saturating there. The qtilde corrections are skipped when the sign was flipped, because they apply when the best fit value is at the POI boundary, which is on the other side of the tested value.
The option has no effect for the two-sided test statistics, whose asymptotic p-value formulae are symmetric in the sign.
Closes ROOT-8257.
🤖 Done with the help of AI