Skip to content

[CI] Streamline Mac config - #23118

Merged
hageboeck merged 2 commits into
root-project:masterfrom
hageboeck:mac_no_incrementals
Aug 21, 2026
Merged

[CI] Streamline Mac config#23118
hageboeck merged 2 commits into
root-project:masterfrom
hageboeck:mac_no_incrementals

Conversation

@hageboeck

@hageboeck hageboeck commented Aug 20, 2026

Copy link
Copy Markdown
Member

For the merged build step, the intention is:

  • The "on: push" build takes github.ref_name and uses the overrides.
  • The nightly build takes inputs.ref_name and does not use overrides.

The logic looks like incrementals are only disabled on some of the
builds, but the operator precedence is such that the expression always
evaluates to false.

Fix root-project#23113
@hageboeck hageboeck self-assigned this Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 15h 37m 33s ⏱️
 3 860 tests  3 860 ✅ 0 💤 0 ❌
79 542 runs  79 542 ✅ 0 💤 0 ❌

Results for commit bdf83be6.

♻️ This comment has been updated with latest results.

@hageboeck
hageboeck force-pushed the mac_no_incrementals branch 2 times, most recently from 6f6b747 to 4a4ee58 Compare August 20, 2026 14:00
@hageboeck
hageboeck marked this pull request as ready for review August 20, 2026 14:04
@hageboeck
hageboeck requested a review from dpiparo as a code owner August 20, 2026 14:04
@hageboeck
hageboeck requested a review from pcanal August 20, 2026 14:09
Comment thread .github/workflows/root-ci.yml Outdated
Co-authored-by: Philippe Canal <pcanal@fnal.gov>
@hageboeck
hageboeck force-pushed the mac_no_incrementals branch from 9b44646 to bdf83be Compare August 20, 2026 15:09

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@hageboeck
hageboeck merged commit 6504e96 into root-project:master Aug 21, 2026
35 checks passed
@hageboeck
hageboeck deleted the mac_no_incrementals branch August 21, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Incremental builds inadvertently disabled on all MacOS

3 participants