Add more tests with TASimage filling - #23119
Merged
Merged
Conversation
Check not only corners, but also number of changed pixels. Compare with expected value calculated as ellipse area
Same as with circle, test different colors and verify produced area Resuse same method - just add switch to create different shapes
Drawn with angle 45 degree, ellipse filling does not work properly
couet
approved these changes
Aug 20, 2026
2 tasks
Test Results 23 files 23 suites 3d 16h 47m 1s ⏱️ Results for commit 2a5ff15. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TASImage::DrawEllips2()works incorrectly when filling tilted ellipse #23120