-
Notifications
You must be signed in to change notification settings - Fork 564
Publish the ABI check comment and labels via #3276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+48
−3
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Publishes the result of the "abi" workflow (abi.yaml) on the pull request: | ||
| # one sticky comment with the per-library ABI verdicts and the | ||
| # "ABI compatible" / "ABI break" label. | ||
| # | ||
| # This is a separate workflow because abi.yaml builds and diffs the pull | ||
| # request's own code. For pull requests from forks GitHub therefore runs it | ||
| # with a read-only token, whatever permissions it asks for, and it cannot | ||
| # write to the PR. workflow_run workflows instead run the workflow file from | ||
| # the default branch of this repository with a normal token; this one never | ||
| # checks out or executes anything from the pull request, it only downloads the | ||
| # report artifacts the abi run uploaded and posts what they say. | ||
| # | ||
| # The pass/fail check on the pull request still comes from abi.yaml; this | ||
| # workflow only adds the comment and the label. It only starts firing once it | ||
| # exists on the default branch, and a first-time contributor's abi run still | ||
| # needs a maintainer's approval before anything is published. | ||
| # | ||
| # See https://github.com/fujitatomoya/ros2-abi-action for details. | ||
| name: abi-report | ||
|
|
||
| on: | ||
| workflow_run: | ||
| # Must match the `name:` of abi.yaml. | ||
| workflows: [abi] | ||
| types: [completed] | ||
|
|
||
| jobs: | ||
| report: | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write # sticky comment + label | ||
| issues: write # label | ||
| actions: read # download the abi run's report artifacts | ||
| uses: fujitatomoya/ros2-abi-action/.github/workflows/report.yml@main | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is exactly what this PR trying to solve.