Skip to content

fix: preserve product and operating system names - #57

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-preserve-product-names
Sep 11, 2026
Merged

fix: preserve product and operating system names#57
chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-preserve-product-names

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Headings currently lowercase parts of GitHub Copilot, Claude Code, Codex, Debian, and Arch Linux. Add these names and standalone Linux to the dictionary to preserve their capitalization.

Found while formatting rstackjs/agent-skills#123.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T07:16:50.685189Z f2694a3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenjiahan
chenjiahan merged commit eab5147 into main Sep 11, 2026
5 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/fix-preserve-product-names branch September 11, 2026 07:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2694a3370

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/dict.ts
'Arch Linux',
'Babel',
'Baseline',
'Claude Code',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Scope multiword matches to the current occurrence

When a heading contains Claude Code, isTerm treats every Code token on that line as protected because it only checks whether the complete term occurs anywhere in the line. Consequently, formatLine('# Claude Code and Writing Code') produces # Claude Code and writing Code instead of lowercasing the unrelated final word. Adding this entry therefore regresses headings that mention the product alongside generic code; multiword-term matching should be tied to the current token occurrence.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant