-
Notifications
You must be signed in to change notification settings - Fork 0
feat: support loading config from explicit path #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f83b47e
feat: support loading config from explicit path
chenjiahan dad7942
fix(config): keep Rstack config loads fresh
chenjiahan 61f31bd
test: rename config loader test directory
chenjiahan bf6ebf6
refactor(config): rely on load-config path resolution
chenjiahan f89affd
test: refine explicit config path coverage
chenjiahan f14ea2c
test: simplify explicit config path coverage
chenjiahan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import { define } from 'rstack'; | ||
|
|
||
| define.app({}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import path from 'node:path'; | ||
| import { afterEach, expect, test } from 'rstack/test'; | ||
| import { getConfigState, loadRstackConfig } from '../../../src/config.ts'; | ||
|
|
||
| const state = getConfigState(); | ||
|
|
||
| afterEach(() => { | ||
| state.configs = {}; | ||
| delete state.configPath; | ||
| }); | ||
|
|
||
| test('should reset config state before and after loading', async () => { | ||
| state.configs = { app: {} }; | ||
| state.configPath = path.join(import.meta.dirname, 'rstack.config.ts'); | ||
|
|
||
| await expect(loadRstackConfig()).rejects.toThrow('test config error'); | ||
| expect(state.configs).toEqual({}); | ||
| }); | ||
|
|
||
| test('should prefer an explicit config path over the state config path', async () => { | ||
| const configFilePath = path.join(import.meta.dirname, 'explicit.config.ts'); | ||
| state.configPath = path.join(import.meta.dirname, 'rstack.config.ts'); | ||
|
|
||
| const { configs, filePath } = await loadRstackConfig({ configFilePath }); | ||
|
|
||
| expect(configs.app).toEqual({}); | ||
| expect(filePath).toBe(configFilePath); | ||
| }); |
File renamed without changes.
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.