Verify insertion of char before a WikiWord dehighlights the WikiWord - #1052
Merged
matsl merged 2 commits intoSep 12, 2026
Merged
Conversation
matsl
changed the title
* test/hywiki-tests.el (hywiki-tests--hywiki-face-regions): Add beg
and end parameter for listing hywiki--word-face in a limited region.
(hywiki-tests--word-at): Use hywiki-tests--hywiki-face-regions for
verifying a non WikiWord is not highlighted.
(hywiki-tests--wikiword-step-check): Add test that inserts a char
before a WikiWord.
* test/hywiki-yki-tests.el
(hywiki--verify-get-buffer-text-with-point-and-highlight-compact):
Add test that inserts a char before a WikiWord.
Added an extra trailing space that makes the test pass. Marked the changes with FIXME comments for future investigations.
matsl
force-pushed
the
pr_add_test_for_insert_char_before_wikiword_dehighlights
branch
from
September 11, 2026 22:45
885b9fa to
a271e50
Compare
matsl
marked this pull request as ready for review
September 11, 2026 22:54
rswgnu
approved these changes
Sep 12, 2026
matsl
deleted the
pr_add_test_for_insert_char_before_wikiword_dehighlights
branch
September 12, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Verify insertion of char before a wikiWord dehighlights.
test/hywiki-tests.el (hywiki-tests--hywiki-face-regions): Add beg
and end parameter for listing hywiki--word-face in a limited region.
(hywiki-tests--word-at): Use hywiki-tests--hywiki-face-regions for
verifying a non WikiWord is not highlighted.
(hywiki-tests--wikiword-step-check): Add test that inserts a char
before a WikiWord.
test/hywiki-yki-tests.el
(hywiki--verify-get-buffer-text-with-point-and-highlight-compact):
Add test that inserts a char before a WikiWord.
Why
This test case was missing.