Skip to content

Mask object addresses in message assertions #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsbt wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −2
Open

Mask object addresses in message assertions #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions test/test_error_highlight.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ def preprocess(msg)
end
end

# A moving GC can relocate the receiver between the expected message baking
# `#inspect` and the error being raised, so the two addresses need not agree.
def mask_addresses(msg)
msg.gsub(/0x\h+/, "0xXXXX")
end

if Exception.method_defined?(:detailed_message)
def assert_error_message(klass, expected_msg, &blk)
omit unless klass < ErrorHighlight::CoreExt
Expand All @@ -55,13 +61,14 @@ def assert_error_message(klass, expected_msg, &blk)
assert_kind_of(Array, spot[:script_lines])
end
end
assert_equal(preprocess(expected_msg).chomp, err.detailed_message(highlight: false).sub(/ \((?:NoMethod|Name)Error\)/, ""))
actual_msg = err.detailed_message(highlight: false).sub(/ \((?:NoMethod|Name)Error\)/, "")
assert_equal(mask_addresses(preprocess(expected_msg).chomp), mask_addresses(actual_msg))
end
else
def assert_error_message(klass, expected_msg, &blk)
omit unless klass < ErrorHighlight::CoreExt
err = assert_raise(klass, &blk)
assert_equal(preprocess(expected_msg).chomp, err.message)
assert_equal(mask_addresses(preprocess(expected_msg).chomp), mask_addresses(err.message))
end
end

Expand Down