Stop redefining IO's wait methods in the java extension - #76
Merged
Conversation
JRuby has had wait, wait_readable and wait_writable in IO since 10.0, so these copies shadow them. They have not kept up either: JRuby 10.1 takes an events mask and a timeout, or a timeout in any position among mode symbols, while these still only understand (timeout, mode). Requiring io/wait takes those forms away again. The C extension already did this, Init_wait has been empty since the methods moved into io.c. The library still loads, it just defines nothing.
headius
approved these changes
Sep 10, 2026
headius
left a comment
headius
left a comment
Contributor
There was a problem hiding this comment.
Yup, even JRuby 9.4 ships some form of IO#wait so let's follow CRuby and remove these.
Contributor
|
@nobu Ok if I release an update? |
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JRuby has had wait, wait_readable and wait_writable in IO since 10.0, so these copies shadow them. They have not kept up either: JRuby 10.1 takes an events mask and a timeout, or a timeout in any position among mode symbols, while these still only understand (timeout, mode). Requiring io/wait takes those forms away again.
The C extension already did this, Init_wait has been empty since the methods moved into io.c. The library still loads, it just defines nothing.