Take #69, #70 and #71, each with a test - #77
Merged
Merged
Conversation
Before the check, read(-1) walked @rbuf_offset backwards and a later read_all handed back bytes an earlier read had already consumed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The case had no branch for it, so the retry loop spun without waiting and without ever reaching the write_timeout. The fake refuses the write until it has been waited on, which turns a regression into a failure rather than a hang. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
LOG_off had no counterpart on the exception path, so a raise from the block or from the source silenced the connection's debug_output for good. The two success cases go with them because the restructure rewrote the method that had no coverage at all. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cherry-picked the three fixes from #69, #70 and #71 unchanged, so they keep Oskar Eichler as their author. I reproduced each symptom on master first, then reviewed the patches against it. Only #71 has room to go wrong, since it restructures five methods, and its success paths come out byte for byte identical. None of the three needed a change.
What those PRs left out, deliberately, is tests, so I wrote them. Each one fails with its own fix reverted. The
:wait_readablefake caps its attempts, so a regression there fails instead of hanging the suite.write_message_by_blockhad no coverage at all, so I also pinned its normal return value and itsbreakcase, neither of which the restructure changes.Generated with Claude Code