Add EnvironmentLoader for ruby-rbs crate - #3050
Draft
dak2 wants to merge 1 commit into
Draft
Conversation
Mirrors RBS::EnvironmentLoader: resolves core, library (with manifest.yaml dependency expansion), and explicit-directory sources in Ruby's load order, then parses each .rbs file once into an Environment. ruby#2954
soutaro
reviewed
Jul 30, 2026
| } | ||
|
|
||
| impl EnvironmentLoader { | ||
| pub fn new() -> Self { |
Member
There was a problem hiding this comment.
Make core_root and stdlib_root required arguments.
soutaro
reviewed
Jul 30, 2026
| /// distinct entries yielded separately by `each_dir`. | ||
| Library { | ||
| name: String, | ||
| version: Option<String>, |
Member
There was a problem hiding this comment.
Suggested change
| version: Option<String>, | |
| path: Path, // or some Path-ish attribute |
Ruby runtime will fill the path for the library root, where adding sig dir name gives the path for the directory of RBS files.
soutaro
reviewed
Jul 30, 2026
| /// stage on worker threads, which requires the loader holding this resolver to | ||
| /// be `Sync`; a supertrait cannot be added later without breaking downstream | ||
| /// implementations, so the bound is here from the start. | ||
| pub trait GemSigResolver: Send + Sync { |
Member
There was a problem hiding this comment.
I think this trait is unnecessary. The library client would pass the resolved paths of each loaded gems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors RBS::EnvironmentLoader: resolves core, library (with manifest.yaml dependency expansion), and explicit-directory sources in Ruby's load order, then parses each .rbs file once into an Environment.
#2954