Skip to content

Treat signature directory paths literally #3115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mame merged 2 commits into from
Sep 18, 2026
+10 −2
Merged

Treat signature directory paths literally #3115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
734fd79
Treat signature directory paths literally
OskarEichler Aug 29, 2026
4f136ff
Add a test for directory paths containing glob metacharacters
mame Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rbs/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,7 +990,7 @@ def run_annotate(args, options)
args.each do |file|
path = Pathname(file)
if path.directory?
Pathname.glob((path + "**/*.rbs").to_s).each do |path|
path.glob("**/*.rbs").each do |path|
stdout.puts "Processing #{path}..."
annotator.annotate_file(path)
end
Expand Down
2 changes: 1 addition & 1 deletion lib/rbs/file_finder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def self.each_file(path, immediate: nil, skip_hidden:, &block)
yield path

when path.directory?
paths = Pathname.glob("#{path}/**/*.rbs")
paths = path.glob("**/*.rbs")

if skip_hidden
paths.select! do |child|
Expand Down
8 changes: 8 additions & 0 deletions test/rbs/file_finder_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,12 @@ def test_dir_path
assert_equal [tmpdir + "_private/app/x.rbs"], FileFinder.each_file(tmpdir + "_private", skip_hidden: true).to_a
assert_equal [tmpdir + "_private/_internal/y.rbs", tmpdir + "_private/app/x.rbs"], FileFinder.each_file(tmpdir + "_private", skip_hidden: false).to_a
end

def test_dir_path_with_glob_metacharacters
(tmpdir / "sig[1]").mkpath
(tmpdir / "sig[1]/c.rbs").write("")

assert_equal [tmpdir + "sig[1]/c.rbs"], FileFinder.each_file(tmpdir + "sig[1]", skip_hidden: true).to_a
assert_equal [tmpdir + "sig[1]/c.rbs"], FileFinder.each_file(tmpdir + "sig[1]", skip_hidden: false).to_a
end
end
Loading