Update singleton - #3152
Open
ksss wants to merge 1 commit into
Open
Update singleton#3152ksss wants to merge 1 commit into
ksss wants to merge 1 commit into
Conversation
ksss
commented
Sep 20, 2026
| assert_send_type '() -> SingletonSingletonTest::TestClass', | ||
| TestClass, :instance | ||
| end | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This test will fail, but making it pass requires breaking changes to the test harness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the singleton module's type definitions to reflect actual usage.
In the current definitions, even the
#instancemethod in standard use cases withinclude Singletondoes not work correctly.This is a breaking change for calls to
Singleton.instance, but this method does not exist in the first place and type checks should not pass for it.To provide correct type definitions,
extend Singleton::SingletonClassMethodsis required alongsideinclude Singletonin each case, which is also the correct behavior.