Fix timezone data dependency on Windows with Ruby 4 and add Toki Pona - #4005
Open
rimsky-yamatov wants to merge 1 commit into
Open
Fix timezone data dependency on Windows with Ruby 4 and add Toki Pona#4005rimsky-yamatov wants to merge 1 commit into
rimsky-yamatov wants to merge 1 commit into
Conversation
|
Hey @rimsky-yamatov PR description says you only fixed the timezone, but it also adds translations to Toki Pona. Could you please separate the changes into two PRs ? One for the timezone fix and another for the translations ? That would make your PR a lot easier to review :) Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the timezone data dependency required for the website to build on Windows with Ruby 4, and add Toki Pona support to the website.
Problem
When running the development server on Windows with Ruby 4, Jekyll fails because TZInfo cannot find a timezone data source.
In addition, Toki Pona content was added to the website and needs to be included in this change.
Changes
tzinfo-dataas a dependency.Testing
Tested with:
bundle exec rake serveThe Jekyll development server now proceeds without the
TZInfo::DataSourceNotFounderror.The newly added Toki Pona content was also checked to ensure it is included correctly in the website.