Closed
Use browser timeout for async target registration#614
Conversation
Co-authored-by: route <414803+route@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Tests (3.3)
Use browser timeout for async target registration
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 3.3 CI was failing in
Tests (3.3)because page creation could raiseFerrum::NoSuchTargetErrorwhile waiting forTarget.createTargetto be reflected back through async target events. The wait path was using the low-level protocol timeout instead of the normal browser operation timeout.Root cause
Ferrum::Context#create_targetwaited for target registration with@client.protocol_timeoutTarget.*event delivery and processingChange
protocol_timeoutscoped to transport-level CDP calls while allowing target creation to complete under normal page-operation timingRegression coverage
Ferrum::Context#create_targetprotocol_timeoutand a larger browsertimeout, then resolvesadd_targetasynchronously to verifycreate_targetwaits on the correct timeout source