Fix check-in reminder scheduling on profile creation - #878
Open
CoryMCodes wants to merge 1 commit into
Open
Conversation
PUT /api/profiles/:id crashed whenever the onboarding reminder step was
completed. The frontend always sets onboarding_reminder, so the
scheduling branch ran for both choices on that step:
- Opting out left checkin_reminder_at nil, and get_reminder_time called
strftime on it.
- Picking a time passed an ActiveSupport::TimeWithZone to perform_in,
which Sidekiq 7 rejects as a non-JSON-native argument.
Extract scheduling into schedule_reminder, which returns nil when there
is no time to schedule against and passes an iso8601 string to the job.
Opting out now cancels the existing job and clears reminder_job_id
instead of leaving a stale one.
CheckinReminderJob is unchanged; it never reads that argument, it only
passes it through when re-enqueueing itself.
Add specs for both branches; all four fail against the previous
controller with the errors above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PUT /api/profiles/:id crashed whenever the onboarding reminder step was
completed. The frontend always sets onboarding_reminder, so the
scheduling branch ran for both choices on that step:
Extract scheduling into schedule_reminder, which returns nil when there
is no time to schedule against and passes an iso8601 string to the job.
Opting out now cancels the existing job and clears reminder_job_id
instead of leaving a stale one.
CheckinReminderJob is unchanged; it never reads that argument, it only
passes it through when re-enqueueing itself.
Add specs for both branches; all four fail against the previous
controller with the errors above.
fixes #877