Remove the primary_sector_single legacy field identifier - #2278
Draft
maebeale wants to merge 6 commits into
Draft
Conversation
…ectors Field identifiers now carry the name their behavior implies: the single-select primary field is primary_sector (was primary_sector_single), the multi-select additional field stays additional_sectors. Drop the legacy lookups the old misnomer created — primary_sector meaning "additional", plus primary_service_area / primary_service_area_single — now that the stored data is consolidated. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rename primary_sector_single → primary_sector in the specs that exercise it, collapse the now-single-scheme professional-fields request spec, and retire the legacy service-area test cases (converted to canonical additional_sectors / primary_sector). Remove the legacy_form_identifiers dev seed and its rake task. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The service-area field identifiers are retired; update the two comment examples and the dashboard spec description to say "sector(s)" so no stale terminology remains. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ield Re-accept the older primary_sector_single identifier alongside the canonical primary_sector so forms still carrying it keep resolving, and document it on the Smart form settings reference page (the drift spec requires every sector identifier to be catalogued). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…r_single Deleting it was premature: primary_sector_single is still an accepted legacy identifier for the primary sector field, so the dev seed that demonstrates a form carrying a legacy identifier is still useful. Trim it to that one surviving scheme (additional sectors and both age-group fields were never renamed, so they stay canonical) and re-wire its rake task. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop the legacy alias now that primary_sector is the canonical primary sector identifier. Merge only after prod form data is migrated from primary_sector_single → primary_sector (see the connected issue). With no legacy identifiers left, the legacy_form_identifiers dev seed and its rake task go too. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 removes one legacy identifier alias + its dev seed; small and contained
primary_sector_single→primary_sector. Stacked on #2275.Closes #2277
Why
#2275 made
primary_sectorthe canonical primary-sector identifier and keptprimary_sector_singleas a temporary legacy alias so existing forms keep resolving. Once prod data is renamed toprimary_sector, the alias is dead code.Changes
FormField::PRIMARY_SECTOR_FIELD_IDENTIFIERS→%w[primary_sector]primary_sector_single"(legacy)" row fromSmartFormFieldslegacy_form_identifiersdev seed + rake task — no legacy identifiers remain