Skip to content

Lint cleanup in VolunteersController - #7146

Merged
compwron merged 1 commit into
mainfrom
lint-26aug26
Aug 26, 2026
Merged

Lint cleanup in VolunteersController#7146
compwron merged 1 commit into
mainfrom
lint-26aug26

Conversation

@compwron

Copy link
Copy Markdown
Collaborator

Why

standardrb app/controllers/volunteers_controller.rb reports one offense on main:

app/controllers/volunteers_controller.rb:230:12: Rails/Blank: Use `if update_volunteer_params[:email].blank?` instead of `unless update_volunteer_params[:email].present?`.

What

  • Fixes that Rails/Blank offense. The file is now clean under the project linter (bin/lint / Standard.rb).

Follow-up commits on this branch extract the index filter-param building and the reactivation SMS body out of the controller, which shrinks index, create, and a 332-char line — the offenses vanilla RuboCop's Metrics/* cops flag (those cops are disabled by Standard.rb, so this is a readability change, not a CI requirement).

How to verify

bundle exec standardrb app/controllers/volunteers_controller.rb
bundle exec rspec spec/system/volunteers

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the ruby Touches Ruby code label Aug 26, 2026
@compwron
compwron marked this pull request as ready for review August 26, 2026 21:54
@compwron
compwron merged commit cea11e5 into main Aug 26, 2026
12 checks passed
@compwron
compwron deleted the lint-26aug26 branch August 26, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Touches Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant