Fix activestorage CVE-2026-66066 patched_versions - #1191
Merged
jasnow merged 3 commits intoJul 29, 2026
Merged
Conversation
The 7.2.x fix shipped in 7.2.3.2, not 7.2.3.1, so "~> 7.2.3.1" wrongly marked the vulnerable 7.2.3.1 as patched and bundler-audit reported no vulnerability. Likewise "~> 8.0.5.1" only matched the 8.0.5.x tine and wrongly flagged 8.0.6+ as vulnerable. Use compound constraints so the affected ranges (<7.2.3.2, 8.0.x<8.0.5.1, 8.1.x<8.1.3.1) are correct. Also fix the advisory date (2027-07-29 -> 2026-07-29).
flavorjones
approved these changes
Jul 29, 2026
Member
|
No don't merge that! |
Member
|
this is not right: because it will consider anything >= 7.2.3.2 to be patched which is incorrect (e.g. 8.0.5 qualifies but is vulnerable) the way you had it was right: |
Member
|
See |
This reverts commit d6259af.
Contributor
Author
Ohhh, you're right, rolled it back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
patched_versionsforactivestorage/CVE-2026-66066are incorrect, causingbundler-auditto under- and over-report the vulnerability.Per the Rails GHSA and the v7.2.3.2 release, the affected ranges are:
activestorage < 7.2.3.2activestorage >= 8.0, < 8.0.5.1activestorage >= 8.1, < 8.1.3.1Two bugs in the current entry:
"~> 7.2.3.1"marks the vulnerable7.2.3.1as patched. The 7.2.x fix shipped in 7.2.3.2, not 7.2.3.1 (the current file even links 7.2.3.2 as the fixed release). As written, an app on the vulnerable7.2.3.1gets a cleanbundle-audit— a false "not vulnerable" for a CVSS 9.5."~> 8.0.5.1"is too narrow.~> 8.0.5.1means>= 8.0.5.1, < 8.0.6, so it wrongly flags 8.0.6+ as still vulnerable.Fix
Use compound constraints (matching the existing convention in e.g.
activerecord/CVE-2022-44566.yml):Verified against the GHSA ranges across 16 boundary versions (7.2.3.1/.2, 7.2.4, 8.0.0/8.0.5.0/8.0.5.1/8.0.6, 8.1.0/8.1.3.0/8.1.3.1, 8.2.0, 9.0.0) — all classifications now match.
Also corrects the advisory
date(2027-07-29→2026-07-29).Full
rspecsuite passes locally (64118 examples, 0 failures).