Add support for marking functions as safe - #3456
Open
DanielEScherzer wants to merge 1 commit into
Open
Conversation
emilio
requested changes
Sep 6, 2026
Author
I guess that works too, I'll rework this |
DanielEScherzer
force-pushed
the
safe_fn_override
branch
from
September 6, 2026 23:12
e2998ba to
eddbd8d
Compare
DanielEScherzer
changed the title
ParseCallbacks method to mark functions as safeIn the same way that `Builder::allowlist_function()` and the command line `--allowlist-function` option permit marking some function as to-be-generated, the new `Builder::safe_function()` method and `--safe-functions` option allow marking functions as safe. Fixes rust-lang#3443
DanielEScherzer
force-pushed
the
safe_fn_override
branch
from
September 6, 2026 23:12
eddbd8d to
ddec868
Compare
emilio
requested changes
Sep 7, 2026
| }) | ||
| }); | ||
|
|
||
| let is_safe = context.options().safe_functions.matches(&name); |
Contributor
There was a problem hiding this comment.
We don't need to check it this early.
| .unsafe_extern_blocks | ||
| .then(|| quote!(unsafe)); | ||
|
|
||
| let mark_fn_safe = if self.is_safe() { |
Contributor
There was a problem hiding this comment.
I think we could do:
let mark_fn_safe = ctx.options().safe_functions.matches(ident).then(|| quote!(safe));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the same way that
Builder::allowlist_function()and the command line--allowlist-functionoption permit marking some function as to-be-generated,the new
Builder::safe_function()method and--safe-functionsoption allowmarking functions as safe.
Fixes #3443