Skip to content

[crater] Also enforce dyn compatibility in (unchecked) type aliases - #161358

Draft
fmease wants to merge 1 commit into
rust-lang:mainfrom
fmease:enf-dyn-compat-in-unck-ty-aliases
Draft

[crater] Also enforce dyn compatibility in (unchecked) type aliases#161358
fmease wants to merge 1 commit into
rust-lang:mainfrom
fmease:enf-dyn-compat-in-unck-ty-aliases

Conversation

@fmease

@fmease fmease commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@fmease fmease added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-types Relevant to the types team, which will review and decide on the PR/issue. needs-crater This change needs a crater run to check for possible breakage in the ecosystem. labels Aug 19, 2026
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 19, 2026
@fmease fmease removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 19, 2026
@fmease

fmease commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 19, 2026
@bors
Auto merge of #161358 - fmease:enf-dyn-compat-in-unck-ty-aliases, r=<…
c0bbd1b 
…try>

[crater] Also enforce dyn compatiblity in (unchecked) type aliases
@fmease fmease changed the title [crater] Also enforce dyn compatiblity in (unchecked) type aliases [crater] Also enforce dyn compatibility in (unchecked) type aliases Aug 19, 2026
fmease
fmease commented Aug 19, 2026
View reviewed changes
Comment thread tests/ui/type-alias/lack-of-wfcheck-gat-generic-const-args.rs Outdated

@fmease fmease Aug 19, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test didn't make much sense to me: "[…] are rejected at the definition site of an eager type alias.": Well yeah, but it had to reference the type alias somewhere (here: in the body of main) for that to happen, so it isn't testing what it says. After all, unchecked type aliases aren't retained in the middle::ty IR, they're eagerly expanded to their RHS, so this behavior has nothing to do with type aliases.

Because of that, I've removed it.

View changes since the review

@rust-bors

rust-bors Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: c0bbd1b (c0bbd1b6d95c5dc13a0e7f2e2c5dfb0387e1f2d4)
Base parent: f7d782a (f7d782a3be46d6bb4b9792fe69a61db389ba1769)

@fmease

fmease commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

@craterbot check

@craterbot

craterbot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-161358 created and queued.
🤖 Automatically detected try build c0bbd1b
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Aug 19, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease
fmease force-pushed the enf-dyn-compat-in-unck-ty-aliases branch 3 times, most recently from 32330c2 to a16442e Compare August 19, 2026 16:30
@theemathas theemathas mentioned this pull request Sep 3, 2026
Draft
@theemathas

theemathas commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@craterbot cancel

See #162233

@craterbot

craterbot commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

🗑️ Experiment pr-161358 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-crater This change needs a crater run to check for possible breakage in the ecosystem. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. T-types Relevant to the types team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fmease @craterbot @rust-log-analyzer @theemathas @rustbot