give next-solver's evaluate_const its own try_evaluate_const logic - #161418
Open
zedddie wants to merge 4 commits into
Open
give next-solver's evaluate_const its own try_evaluate_const logic#161418zedddie wants to merge 4 commits into
evaluate_const its own try_evaluate_const logic#161418zedddie wants to merge 4 commits into
Conversation
rustbot
added
S-waiting-on-author
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7 tasks
zedddie
force-pushed
the
evaluate_const-stuff
branch
from
August 24, 2026 17:15
00a3838 to
92b2dea
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zedddie
force-pushed
the
evaluate_const-stuff
branch
from
August 27, 2026 09:49
92b2dea to
5a6ab62
Compare
This comment has been minimized.
This comment has been minimized.
zedddie
force-pushed
the
evaluate_const-stuff
branch
from
August 28, 2026 20:32
5a6ab62 to
c40c0cd
Compare
This comment has been minimized.
This comment has been minimized.
zedddie
force-pushed
the
evaluate_const-stuff
branch
from
August 29, 2026 13:52
c40c0cd to
67b25fa
Compare
zedddie
force-pushed
the
evaluate_const-stuff
branch
from
September 8, 2026 03:49
67b25fa to
c814483
Compare
zedddie
changed the title
evaluate_const its own try_evaluate_const logic
zedddie
marked this pull request as ready for review
September 8, 2026 04:15
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently evaluating type-level constants is convoluted as code is split in a lot of scattered functions across compiler which makes it hard to reason about. This PR refactors next-solver's CTFE entry point and should not change any behavior.
for context see #project-const-generics > evaluate_const is scary
r? BoxyUwU