Skip to content

Revert "bootstrap: Enable rustdoc mergeable CCI for std and internal docs #161716" - #162339

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
jieyouxu:revert-mergeable-cci
Sep 6, 2026
Merged

Revert "bootstrap: Enable rustdoc mergeable CCI for std and internal docs #161716"#162339
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
jieyouxu:revert-mergeable-cci

Conversation

@jieyouxu

@jieyouxu jieyouxu commented Sep 5, 2026

Copy link
Copy Markdown
Member

cc #162334.

It seems that #161716 still has some issues with combining cross-crate info? Let's revert for now and reland once we figure out why we are regressing the search results 🤔 It's not obvious to me.

I built rustc-docs dist component locally, and at least locally with #161716 reverted I can find rustc::ast::Attribute "normally" from the search results.

This reverts commit a69a632, reversing changes made to c33d8f3.

This also reverts #162318, since #162318 fixes an regression introduced in #162334.

r? @Kobzol (or notriddle/bootstrap/rustdoc)
cc @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 5, 2026
@rustbot

rustbot commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@rustbot

This comment has been minimized.

@jieyouxu jieyouxu changed the title Revert "Auto merge of #161716 - notriddle:remake-bootstrap-doc-mergeable, r=Kobzol,jieyouxu" Revert "bootstrap: Enable rustdoc mergeable CCI for std and internal docs #161716" Sep 5, 2026
@Kobzol

Kobzol commented Sep 5, 2026

Copy link
Copy Markdown
Member

Weird. I thought I diffed the generated docs locally and they were essentially the same. Maybe I didn't diff the JS files.. 🤔

Thanks.

@bors r+

@rust-bors

rust-bors Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 72aea01 has been approved by Kobzol

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 5, 2026
@Zalathar

Zalathar commented Sep 6, 2026

Copy link
Copy Markdown
Member

The conflicting change is probably #162318, which I believe was an unrelated bugfix for the changes being reverted.

So if we go ahead with the revert, it should be fine to lose that change as long as (e.g.) ./x doc rustc_mir_build --open still manages to open the docs.

@Zalathar

Zalathar commented Sep 6, 2026

Copy link
Copy Markdown
Member

I have manually verified that after reverting both #162318 and #161716, ./x doc rustc_mir_build --open works fine, so my PR was indeed fixing a newly-introduced bug in the PR that is being reverted.

@notriddle

Copy link
Copy Markdown
Contributor

I also tried running the notriddle@dbd6be9 test case on it, and it passes.

…oc-mergeable, r=Kobzol,jieyouxu"

This reverts commit a69a632, reversing
changes made to c33d8f3.
@jieyouxu
jieyouxu force-pushed the revert-mergeable-cci branch from 72aea01 to c84edb3 Compare September 6, 2026 08:53
@rustbot

rustbot commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

rustbot commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@jieyouxu

jieyouxu commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

Rebased. Now the revert is effectively both:

  1. rustdoc: Enabling mergeable CCI broke the search functionality for the stdlib and for our internal docs #162334
  2. bootstrap: Fix broken path for ./x doc compiler/rustc --open #162318 (since this is a follow-up fix for rustdoc: Enabling mergeable CCI broke the search functionality for the stdlib and for our internal docs #162334)

I checked locally that ./x doc rustc_middle --open still opens rustc_main docs.

@jieyouxu

jieyouxu commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

@bors r=Kobzol

@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c84edb3 has been approved by Kobzol

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 6, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #162032 (remove more trivial regions in evaluate_added_goals_and_make_canonical_response)
 - #161607 (Add #[track_caller] to signed integer div/rem methods)
 - #162339 (Revert "bootstrap: Enable rustdoc mergeable CCI for std and internal docs #161716")
 - #162158 (Revise documentation of `NumBuffer` and `format_into()`.)
@rust-bors
rust-bors Bot merged commit fbb1ea3 into rust-lang:main Sep 6, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 6, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
Rollup merge of #162339 - jieyouxu:revert-mergeable-cci, r=Kobzol

Revert "bootstrap: Enable rustdoc mergeable CCI for std and internal docs #161716"

cc #162334.

It seems that #161716 still has some issues with combining cross-crate info? Let's revert for now and reland once we figure out why we are regressing the search results 🤔 It's not obvious to me.

I built `rustc-docs` dist component locally, and at least locally with #161716 reverted I can find `rustc::ast::Attribute` "normally" from the search results.

This reverts commit a69a632, reversing changes made to c33d8f3.

This also reverts #162318, since #162318 fixes an regression introduced in #162334.

r? @Kobzol (or notriddle/bootstrap/rustdoc)
cc @notriddle
@jieyouxu
jieyouxu deleted the revert-mergeable-cci branch September 6, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants