Port stdarch-gen-arm to stdarch-gen-common - #2200
Merged
Merged
Conversation
Kobzol
reviewed
Aug 4, 2026
xonx4l
force-pushed
the
port-stdarch-gen-arm-to-common
branch
from
August 12, 2026 11:19
fe32ee8 to
a38619c
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Kobzol
approved these changes
Aug 12, 2026
folkertdev
reviewed
Aug 12, 2026
Comment on lines
+328
to
+329
| env: | ||
| STDARCH_GEN_MODE: check |
Contributor
There was a problem hiding this comment.
can we factor this out (so put it below runs-on on line 324)?
Comment on lines
+38
to
+39
| // The output folder for this spec file (`<out_base>/<arch>/<feature>/`) the | ||
| // directory the harness checks/blesses against. |
Contributor
There was a problem hiding this comment.
this doesn't quite make sense as a sentence, can you rephrase?
Comment on lines
+77
to
+81
| if matches!(i.test, Test::Load(..)) { | ||
| Some(i.clone()) | ||
| } else { | ||
| None | ||
| } |
Contributor
There was a problem hiding this comment.
this can be a match right? would be shorter too.
folkertdev
approved these changes
Aug 12, 2026
xonx4l
force-pushed
the
port-stdarch-gen-arm-to-common
branch
from
August 12, 2026 15:57
0f1ce0b to
310bd72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Port's stdarch-gen-arm to stdarch-gen-common harness .
Since
run_generatoroperates on a single folder butstdarch-gen-armoutputs to manycore_arch/src/<arch>/<feature>/folders main now callsrun_generatoronce per spec filepassing that spec's output folder as the directory to check/bless.
Dropped the old stdout fallback as the harness now always writes to a real folder.
r? @folkertdev