Generate lockfile in intrinsic-test - #2202
Conversation
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| )?; | ||
| write!( | ||
| lockfile, | ||
| r#"# This file is automatically @generated by Cargo. |
There was a problem hiding this comment.
should we really hardcode this (as a string)?
There was a problem hiding this comment.
This is the exact text that Cargo would produce. I could move it to a separate text file, but it isn't going to be automatically updateable either way. Without the Cargo.toml files generated by intrinsic-test, cargo generate-lockfile would just error. So I think updating it would be generate a workspace using intrinsic-test, run cargo update in this workspace and then copy the start of Cargo.lock here.
257af44 to
ab50708
Compare
This comment has been minimized.
This comment has been minimized.
|
How did this cause a miscompilation in CI??? |
This allows building the resulting workspace with --locked.
ab50708 to
662c439
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Rebased and CI passes just fine now. |
This allows building the resulting workspace with --locked.
Fixes #2193