Skip to content

Generate lockfile in intrinsic-test - #2202

Open
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:intrinsic_test_lockfile
Open

Generate lockfile in intrinsic-test#2202
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:intrinsic_test_lockfile

Conversation

@bjorn3

@bjorn3 bjorn3 commented Aug 5, 2026

Copy link
Copy Markdown
Member

This allows building the resulting workspace with --locked.

Fixes #2193

@rustbot

rustbot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn
  • @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn expanded to Amanieu, adamgemmell, davidtwco, folkertdev, sayantn
  • Random selection from Amanieu, adamgemmell, davidtwco, folkertdev, sayantn

@folkertdev folkertdev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

)?;
write!(
lockfile,
r#"# This file is automatically @generated by Cargo.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we really hardcode this (as a string)?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the exact text that Cargo would produce. I could move it to a separate text file, but it isn't going to be automatically updateable either way. Without the Cargo.toml files generated by intrinsic-test, cargo generate-lockfile would just error. So I think updating it would be generate a workspace using intrinsic-test, run cargo update in this workspace and then copy the start of Cargo.lock here.

@bjorn3
bjorn3 force-pushed the intrinsic_test_lockfile branch from 257af44 to ab50708 Compare August 12, 2026 15:44
@rustbot

This comment has been minimized.

@bjorn3

bjorn3 commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

How did this cause a miscompilation in CI???

---- core_arch::x86::avx512fp16::tests::test_mm256_add_ph stdout ----

thread 'core_arch::x86::avx512fp16::tests::test_mm256_add_ph' (5956) panicked at crates\core_arch\src\x86\avx512fp16.rs:17729:9:
assertion `left == right` failed
  left: Simd(0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40)
 right: Simd(0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40, 0x4c40)

This allows building the resulting workspace with --locked.
@bjorn3
bjorn3 force-pushed the intrinsic_test_lockfile branch from ab50708 to 662c439 Compare August 13, 2026 12:27
@rustbot

rustbot commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bjorn3

bjorn3 commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

Rebased and CI passes just fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ship lockfile with intrinsic-test

3 participants