feat: make enums ABI-compatible - #30
Merged
Merged
Conversation
phip1611
approved these changes
Aug 21, 2026
phip1611
left a comment
phip1611
left a comment
Member
There was a problem hiding this comment.
lgtm but please check CI again
Member
Author
|
Oh, right. I should have tested this. This does not work for types where we provide spec-guided typed accessors, so |
mkroening
force-pushed
the
try-from-primitive
branch
from
August 21, 2026 11:05
320fa2c to
ce43c66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe implementing
TryFromPrimitive, which also returns the original number in the error case, is more useful than havingUnknowncatch-all variants for all enums.This also makes the types ABI-compatible, which is still to be used with care when using foreign data, but that is how all Rust enums work until we have unnamed enum variants.