feat(security): converge portfolio admission semantics - #218
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SecurityAdmissionV1over fresh coverage, Dependabot, CodeQL, and secret-scanning evidence0.11.0and legacy compatibility fields, with additive reason/count fieldsKill test
The live strict gate already combined all three providers, but risk, decision, weekly, and Markdown surfaces still used Dependabot-only semantics. A CodeQL High or open secret could therefore block one surface and disappear from another. The gap survived.
Security properties
SECURITY_*reason codes identify the failed admission predicateVerification
Exact head:
0671717b(full SHA available in PR metadata)pytest -q: 3484 passed, 2 skippedruff check src tests: passedmypy src/security_admission.py --ignore-missing-imports: passed--check: passedgit diff --check: passedClaim ceiling
This proves exact-revision source, deterministic fixture, local test, and live-snapshot replay readiness. CI/review, protected-branch merge, downstream consumer repins, installed-runtime uptake, and natural scheduler evidence remain separate until read back.