feat(terraform)!: accept scoped Cloudflare credentials (CTK-651) - #17
Conversation
Shared Terraform workflows required an account-wide Cloudflare key and email, preventing the scoped-token cutover required by CTK-647. The new immutable interface accepts one optional cloudflare-api-token secret and exports only CLOUDFLARE_API_TOKEN. Existing SHA-pinned callers remain unchanged until their credential and provider proofs are ready. Actionlint 1.7.12 accepted both workflows and disposable token/non-Cloudflare callers. Its native workflow-call validator rejected both obsolete global-key callers. No direct @main consumers or legacy credential examples were found. No credentials or infrastructure were changed. References CTK-651
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughBoth reusable Terraform workflows replace the Cloudflare API key and email secrets with one scoped API token secret. Each workflow exports the token through ChangesCloudflare token workflow configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to Terraform plan and apply workflows now use an optional scoped Cloudflare API token instead of the legacy key and email pair. The updated interface is consistent across both workflows, with no current merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Summary
The shared Terraform interface required a global Cloudflare key/email pair, blocking the scoped-token
cutover in CTK-647. This new immutable interface accepts
cloudflare-api-tokenand exports onlyCLOUDFLARE_API_TOKEN. Terraform callers without Cloudflare remain supported. Existing CTK callersremain on their working old SHA until a scoped credential and controlled plan/apply/R2 proof exist.
Verification
Checksum-verified actionlint 1.7.12 passed both workflows. Disposable native reusable-workflow
callers passed with scoped credentials and without Cloudflare; obsolete global-key callers failed
with the expected undefined-secret error. The disposable files were removed. Owner-wide code search
found only SHA-pinned CTK callers and no direct
@mainconsumers; repository documentation has nolegacy credential examples. No production or credential mutation was performed.
The requested CodeRabbit full review
covered both changed workflow files at this exact head and reported no actionable comments
(run
3a060c76-3ac1-46f9-ba76-f8fd6cfb26e7). This is not live provider/R2 authorization proof.Reviewed immutable SHA:
f9f6590dfc77b106ee82e4b698cfb7e0bb986864. This is the reviewed-interface prerequisite for P14,not evidence that credential provisioning or the CTK caller migration is complete.
Fixes CTK-651