Fix table round-tripping. - #486
Conversation
The table from Biomodel 197 was being mangled both going and coming; this fixes both. We should also push them upstream to the source libraries, too.
Pulled in the latest changes from maddy, and added two of my PRs that have not yet been accepted, but are needed for libsbml.
|
@luciansmith that looks great, if anything it is unfortunate, that the changes from: 92a3f5c are undone with the commit. Those were needed last nov to compile. |
|
I can certainly add them back in, but it's weird that everything seems to be passing/compiling without the changes? Did the failing compiler change, or something? |
it failed on another system, not the one we were testing under. Anyways it would be great to have it in, thanks |
|
Got it. Do you remember which one? I ask just because I'd like to include that information when I post a PR to the original library. |
Reintroduced 92a3f5c fix.
|
Changes added! |
fbergmann
left a comment
fbergmann
left a comment
There was a problem hiding this comment.
@luciansmith thank you so much
2 participants
The table from Biomodel 197 was being mangled both going and coming; this fixes both. We should also push them upstream to the source libraries, too.