Skip to content

Improvement/cldsrv 966/support anon req limiting - #6249

Open
tmacro wants to merge 4 commits into
development/9.3from
improvement/CLDSRV-966/support_anon_req_limiting
Open

Improvement/cldsrv 966/support anon req limiting#6249
tmacro wants to merge 4 commits into
development/9.3from
improvement/CLDSRV-966/support_anon_req_limiting

Conversation

@tmacro

@tmacro tmacro commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Support rate limiting anonymous requests & cross-account requests when there is a cold bucketOwner cache.
If the account rate limit config has not been retrieved from Vault during request auth the an extra call to Vault is done to retrieve the bucket owner's rate limit config.

Another small improvement is included (CLDSRV-969) to allow setting burst capacity to 0 .

@bert-e

bert-e commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Aug 7, 2026
@bert-e

bert-e commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@tmacro

tmacro commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/create_integration_branches

@tmacro
tmacro force-pushed the improvement/CLDSRV-966/support_anon_req_limiting branch from 1130021 to 780528d Compare August 7, 2026 15:42
@tmacro

tmacro commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/reset

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.18%. Comparing base (cbc8519) to head (803a6f1).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/metadata/metadataUtils.js 91.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/api.js 93.63% <100.00%> (-0.05%) ⬇️
lib/api/apiUtils/rateLimit/config.js 100.00% <100.00%> (ø)
lib/api/apiUtils/rateLimit/helpers.js 100.00% <100.00%> (ø)
lib/metadata/metadataUtils.js 94.73% <91.66%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.3    #6249      +/-   ##
===================================================
- Coverage            85.20%   85.18%   -0.02%     
===================================================
  Files                  206      206              
  Lines                13424    13434      +10     
===================================================
+ Hits                 11438    11444       +6     
- Misses                1986     1990       +4     
Flag Coverage Δ
file-ft-tests 68.33% <80.00%> (+<0.01%) ⬆️
file-ft-tests-null-compat 68.84% <80.00%> (-0.06%) ⬇️
kmip-ft-tests 28.36% <62.22%> (-0.01%) ⬇️
mongo-v0-ft-tests 69.58% <80.00%> (-0.04%) ⬇️
mongo-v1-ft-tests 69.53% <80.00%> (-0.04%) ⬇️
multiple-backend 36.82% <68.88%> (-0.02%) ⬇️
sur-tests 35.96% <68.88%> (-0.84%) ⬇️
sur-tests-inflights 37.80% <68.88%> (-0.01%) ⬇️
unit 71.18% <95.55%> (+0.09%) ⬆️
utapi-v2-tests 34.61% <68.88%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scality scality deleted a comment from bert-e Aug 7, 2026
@bert-e

bert-e commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@scality scality deleted a comment from bert-e Aug 7, 2026
Comment thread lib/metadata/metadataUtils.js Dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants