Mark non-security md5 usage to allow for compatibility with fips environments - #970
Open
mykaul wants to merge 1 commit into
Open
Mark non-security md5 usage to allow for compatibility with fips environments#970mykaul wants to merge 1 commit into
mykaul wants to merge 1 commit into
Conversation
environments patch by Luke Ratcliffe and Brad Schoening; reviewed by Bret McGuire and Brad Schoening
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
md5usage inMD5Token.hash_fnwithusedforsecurity=Falseso the driver works in FIPS-enforced Python environments, which reject non-approved hash algorithms unless explicitly marked as not used for security purposes.Test plan
tests/unit) locally;test_metadata.pypasses in full, including allMD5Token/Tokentests🤖 Generated with Claude Code