[BREAKING] Add error displays for trouble loading model files - #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #663, will provide more insight on what's going wrong and possibly alert users on how to find a workaround (i.e. place files in a place macOS can grant permission to).
This doesn't resolve the Issue, but should help give information in general.
Breaking change--signature of
LoadFileAtCurrentIndex()is altered.PR Checklist
format.bash?in more detail...
Summary
-1.(FAILED)state with a specific directory-enumeration explanation for that case.This does not attempt to bypass macOS permissions. It prevents a suspected parent-directory scan failure from being silently ignored and distinguishes it from unrelated browser-navigation failures.
Verification
Built the universal Debug AU successfully for arm64 and x86_64:
xcodebuild -project NeuralAmpModeler/projects/NeuralAmpModeler-macOS.xcodeproj -target AU -configuration Debug -xcconfig NeuralAmpModeler/config/NeuralAmpModeler-mac.xcconfig CODE_SIGNING_ALLOWED=NO buildReproduced the original silent behavior in Logic Pro 12.3 with known-good
.namand.wavfiles whose exact paths were readable but whose parent directory could not be enumerated.Confirmed that the compiled AU contains both the specific file-picker/index-
-1diagnostic and the generic unexpected-selection diagnostic.