Conversation
Now they are 1:1 so the distinction is mostly internal. This allows state tracking to be a bit simpler.
Member
Author
|
@SimonSapin not sure how you feel about this, the main point I wanted to get out of this is to be able to not track at_start_of separately, but I think it makes sense in general now that |
Member
|
Aren’t there tests that run the tokenizer by itsef? |
emilio
force-pushed
the
collapse-tokenizer
branch
from
September 15, 2026 11:23
c4ff03b to
d520608
Compare
Member
Author
Not really |
Member
Author
|
Fixed CI (msrv didn't support the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now they are 1:1 so the distinction is mostly internal. This allows
state tracking to be a bit simpler.