Skip to content

Correct iterator collection and partial-retention benchmarks - #597

Open
charliermarsh wants to merge 1 commit into
servo:v2from
astral-sh:charlie/codex-benchmark-coverage
Open

Correct iterator collection and partial-retention benchmarks#597
charliermarsh wants to merge 1 commit into
servo:v2from
astral-sh:charlie/codex-benchmark-coverage

Conversation

@charliermarsh

Copy link
Copy Markdown

Summary

bench_from_iter currently measures conversion from a slice, and bench_retain_mut_half keeps every element because its input is filled with the even value 16.

We now collect a copied iterator in the collection benchmarks and use consecutive integers in the retention benchmarks, so the half-retention cases actually remove half the elements. This applies to both SmallVec and the Vec controls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant